Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise errors on specific types of fallback in cudf.pandas #17268

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Raise errors on specific types of fallback in cudf.pandas #17268

merged 5 commits into from
Nov 13, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Nov 7, 2024 •
edited
Loading

Description

Closes #14975

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Nov 7, 2024
@Matt711 Matt711 self-assigned this Nov 7, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 7, 2024
@Matt711 Matt711 marked this pull request as ready for review November 7, 2024 21:04
@Matt711 Matt711 requested a review from a team as a code owner November 7, 2024 21:04
@Matt711 Matt711 requested review from vyasr and bdice November 7, 2024 21:04
vyasr
vyasr requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be super helpful, thanks Matt! I have some suggestions to clean things up and make the reporting a little more informative.

python/cudf/cudf/pandas/fast_slow_proxy.py Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
python/cudf/cudf_pandas_tests/test_cudf_pandas.py Show resolved Hide resolved
vyasr
vyasr approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt711
Copy link
Contributor Author

Matt711 commented Nov 13, 2024

/merge

@rapids-bot rapids-bot bot merged commit 76a5e32 into rapidsai:branch-24.12 Nov 13, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Offer more control over CPU fallback in cudf.pandas
2 participants
@Matt711 @vyasr